feat: group commit files into batches #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
commented
Aug 24, 2022
| * @param {string} message the message of the new commit | ||
| * @returns {Promise<string>} the new commit SHA | ||
| */ | ||
| export async function createCommit( |
There was a problem hiding this comment.
This was moved to a separate module for ease of mocking.
chingor13
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
bcoe
approved these changes
Aug 24, 2022
| @@ -53,6 +56,15 @@ export function generateTreeObjects(changes: Changes): TreeObject[] { | |||
| return tree; | |||
| } | |||
|
|
|||
| function* inGroupsOf<T>( | |||
There was a problem hiding this comment.
I like the use of the generator.
nit: since it's only used in one place, I wonder if it's a premature abstraction, might just have gone with function *commitBatch.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
🤖 I have created a release *beep* *boop* --- ## [4.1.0](v4.0.1...v4.1.0) (2022-08-24) ### Features * group commit files into batches ([#398](#398)) ([e3815d5](e3815d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a new option for
filesPerCommitwhich defaults to 100. If there are more than this limit,code-suggesterwill split into groups of files and make multiple commits. For most use cases, this is a no-op. For larger monorepos, you may see multiple commits.Fixes #397
Ran the following command:
with a few test files in my working directory to create: #401 which has multiple commits.